Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metafor::rma tidiers - work in progress #674
metafor::rma tidiers - work in progress #674
Changes from 13 commits
ea0234f
77cd17b
b85e01d
725c33a
219d932
7078e2b
0b70c4a
55ed153
a4ffcf5
1b69212
0a7c4f6
26d8d63
273dfc1
53cd56c
d68710e
3bcf4fb
b6d23b5
5b4e6d7
9f31411
15d50ab
9218953
2ba35ff
fdd77be
d857e57
d5834cb
5f896bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the templating trick to pull in standard boilerplate. i.e.:
rather than this first line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would link to all the function that create rma objects here. That is, something along the lines of:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do these arguments get based too? Link to the documentation of that function to make it easier for users trying to track that down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, they actually aren't used but need to be there to match the generic. I seem to recall some methods in broom saying something like
Additional arguments (not used)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they aren't getting used the standard way to document them is with
@template param_unused_dots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at https://github.com/tidymodels/broom/blob/master/R/betareg-tidiers.R#L8 for an example of how to document the tidier return. There are three separate functions
return_tidy()
, ...,return_augment()
to look at. Also I definitely need to document how to use these better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask why the
NA
here? Also, would you consider usingbind_cols()
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NA
is for the p values for the individual studies, which aren't in the model. Only the summary estimate returns a p value. I don't mind switching tobind_cols()
, but I'll have to change a few things since it's strict about all the objects having the same lengthThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
tibble::remove_rownames()
is necessary if you usetibble::as_tibble()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! These are leftover from when I first wrote these, which was prior to broom using tibble
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a
has_rownames()
helper somewhere that you can use here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to change the approach in these lines to make it a little clearer what is happening because the rownames aren't coming from the usual place in this model
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.