[release-3.0]: config support rocksdb doubly skiplist to optimize reverse-scan #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Little-Wallace
changed the title
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
|
/run-all-tests |
|
merge into master branch first? |
|
/test |
hicqu
approved these changes
Sep 9, 2019
|
/run-all-tests |
|
/run-integration-cop-push-down-test tidb=release-3.0 pd=release-3.0 tidb-test=pr/885 |
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
|
/run-all-tests |
|
/run-all-tests |
|
@Little-Wallace merge failed. |
|
/run-integration-common-test |
1 similar comment
|
/run-integration-common-test |
|
/run-integration-common-test tidb-test=pr/883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Little-Wallace bupt2013211450@gmail.com
What have you changed?
I have added one new memtable structure
DoublySkipListinto Rocksdb, which is similar toInlineSkipListbut optimize performance ofIterator::Prev(), which is used in reversed range query. I add a configuration option to enable this feature.What is the type of the changes?
Pick one of the following and delete the others:
How is the PR tested?
Unit tests
I have also tested this structure in
RocksDBrepo by unit tests.Does this PR affect documentation (docs) or should it be mentioned in the release notes?
Yes. Set
enable_doubly_skiplistin tikv.conf to enable this feature.Does this PR affect
tidb-ansible?No
Refer to a related PR or issue link (optional)
You can see the details in this PR: tikv/rocksdb#116