Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batch split region command and empty batch command #5470

Merged
merged 5 commits into from
Sep 18, 2019
Merged

Support batch split region command and empty batch command #5470

merged 5 commits into from
Sep 18, 2019

Conversation

disksing
Copy link
Contributor

What have you changed?

Cherry-pick #5001 #5268 #5466

What is the type of the changes?

  • Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

unit-tests

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

NOTE: Does not support new TiDB run with old TiKV. For example, TiDB v3.0.4 + TiKV v3.0.0.

Does this PR affect tidb-ansible?

If there is a configuration or metrics change, please file a PR in tidb-ansible, and add the PR number here.

Refer to a related PR or issue link (optional)

#5001 #5268 #5466

Benchmark result if necessary (optional)

None

Any examples? (optional)

None

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the type/cherry-pick Type: PR - Cherry pick label Sep 17, 2019
disksing and others added 4 commits September 17, 2019 15:03
Signed-off-by: disksing <i@disksing.com>
* server/service: adapt unordered split keys

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@disksing
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche
Copy link
Member

Could we use the tag NeedCherryPickxxx?

@disksing
Copy link
Contributor Author

@AndreMouche I don't think bot can properly handle it because it depends on another kvproto branch.

@disksing disksing merged commit a99c22d into tikv:release-3.0 Sep 18, 2019
@disksing disksing deleted the cherry branch September 18, 2019 03:50
@disksing disksing added the needs-cherry-pick-release-3.1 Type: Need cherry pick to release 3.1 label Nov 6, 2019
@disksing
Copy link
Contributor Author

disksing commented Nov 6, 2019

/cherry-pick

@disksing
Copy link
Contributor Author

disksing commented Nov 6, 2019

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

cherry pick to release-3.1 failed

disksing added a commit that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.1 Type: Need cherry pick to release 3.1 type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants