-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batch split region command and empty batch command #5470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
* server/service: adapt unordered split keys Signed-off-by: disksing <i@disksing.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
/run-all-tests |
AndreMouche
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could we use the tag |
@AndreMouche I don't think bot can properly handle it because it depends on another kvproto branch. |
hicqu
approved these changes
Sep 18, 2019
disksing
added
the
needs-cherry-pick-release-3.1
Type: Need cherry pick to release 3.1
label
Nov 6, 2019
/cherry-pick |
/run-cherry-picker |
cherry pick to release-3.1 failed |
disksing
added a commit
that referenced
this pull request
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-cherry-pick-release-3.1
Type: Need cherry pick to release 3.1
type/cherry-pick
Type: PR - Cherry pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed?
Cherry-pick #5001 #5268 #5466
What is the type of the changes?
How is the PR tested?
unit-tests
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
NOTE: Does not support new TiDB run with old TiKV. For example, TiDB v3.0.4 + TiKV v3.0.0.
Does this PR affect
tidb-ansible
?If there is a configuration or metrics change, please file a PR in tidb-ansible, and add the PR number here.
Refer to a related PR or issue link (optional)
#5001 #5268 #5466
Benchmark result if necessary (optional)
None
Any examples? (optional)
None