Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix rolling_update_fail when using Arrow format. #5754

Merged
merged 4 commits into from Oct 31, 2019

Conversation

wshwsh12
Copy link
Contributor

What have you changed?

In pingcap/tipb#135 , I change the photo and use the same number to indicate it. It will cause a compatibility problem, and rolling_update will fail.

In this pr, I use a new number to indicate the new field.

What is the type of the changes?

  • Bugfix (a change which fixes an issue)

How is the PR tested?

  • Integration test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

Does this PR affect tidb-ansible?

Refer to a related PR or issue link (optional)

pingcap/tidb#12899
pingcap/tipb#145

Benchmark result if necessary (optional)

Any examples? (optional)

Signed-off-by: wshwsh12 <793703860@qq.com>
@wshwsh12
Copy link
Contributor Author

/run-all-tests tidb=pr/12899

@wshwsh12
Copy link
Contributor Author

/run-all-tests tidb=release-3.0 pd=release-3.0 tidb-test=release-3.0

@wshwsh12
Copy link
Contributor Author

/run-all-tests tidb=pr/12899

Signed-off-by: wshwsh12 <793703860@qq.com>
@breezewish
Copy link
Member

/run-all-tests tidb=pr/12899

Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breezewish
Copy link
Member

/run-all-tests tidb=pr/12899

@breezewish breezewish changed the title [WIP]*: fix rolling_update_fail when using Arrow format. *: fix rolling_update_fail when using Arrow format. Oct 29, 2019
@wshwsh12
Copy link
Contributor Author

/run-all-tests tidb=pr/12899

@breezewish breezewish merged commit 109624c into tikv:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants