Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc: config gc io limit dynamically (#5769) #5957

Conversation

youjiali1995
Copy link
Contributor

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What have you changed?

Cherry pick #5769

@youjiali1995 youjiali1995 added component/tikv-ctl Component: TiKV Control type/cherry-pick Type: PR - Cherry pick priority/release-blocker This PR blocks a release. Please review it ASAP. labels Nov 19, 2019
Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youjiali1995 youjiali1995 added this to the v3.0.6 milestone Nov 19, 2019
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsyh
Copy link

ericsyh commented Nov 19, 2019

/run-all-tests

@AndreMouche
Copy link
Member

/merge

@sre-bot sre-bot added the status/can-merge Status: Can merge to base branch label Nov 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

Your auto merge job has been accepted, waiting for 5938

@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

@youjiali1995 merge failed.

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995 youjiali1995 force-pushed the cherry-pick-dynamically-change-gc-io-limit branch from c886071 to 5b6b36d Compare November 19, 2019 07:52
@youjiali1995
Copy link
Contributor Author

@AndreMouche Merge failed.

@youjiali1995
Copy link
Contributor Author

@AndreMouche

Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

Your auto merge job has been accepted, waiting for 5965

@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

/run-all-tests

@sre-bot sre-bot merged commit a285a54 into tikv:release-3.0 Nov 20, 2019
@youjiali1995 youjiali1995 deleted the cherry-pick-dynamically-change-gc-io-limit branch November 20, 2019 02:21
youjiali1995 added a commit to youjiali1995/tikv that referenced this pull request Nov 25, 2019
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
sre-bot pushed a commit that referenced this pull request Nov 25, 2019
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv-ctl Component: TiKV Control priority/release-blocker This PR blocks a release. Please review it ASAP. status/can-merge Status: Can merge to base branch type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants