Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sst_importer: add metrics (#6395) #6404

Merged
merged 2 commits into from Jan 3, 2020
Merged

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Jan 3, 2020

cherry-pick #6395 to release-3.1

What have you changed?

Please explain in detail what the changes are in this PR and why they are needed:

  • Summarize your change
  • How does this PR work? Include a brief introduction for any changed logic (optional)
  • Separately describe each logical change (optional)
  • Describe any limitations of the current code (optional)

Don't assume reviewers understand the original issue.

What is the type of the changes?

  • New feature (a change which adds functionality)
  • Improvement (a change which is an improvement to an existing feature)
  • Bugfix (a change which fixes an issue)
  • Engineering (engineering change which doesn't change any feature or fix any issue)
  • Misc (other changes)

How is the PR tested?

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

Does this PR affect tidb-ansible?

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Any examples? (optional)

@AndreMouche AndreMouche modified the milestones: v3.1.0-beta.2, v3.1.0-beta.1 Jan 3, 2020
* sst_importer: add metrics

Signed-off-by: luancheng <luancheng@pingcap.com>
@overvenus
Copy link
Member

/run-integration-tests

@AndreMouche AndreMouche merged commit e5568d4 into tikv:release-3.1 Jan 3, 2020
@AndreMouche AndreMouche mentioned this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants