Drop Julia <1.6. Reduce code duplication by introducing ProgressCore #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
changed the title
IanButterworth
force-pushed
the
ib/progress_core
branch
from
23319f2
to
1959e37
Compare
MarcMush
reviewed
Mar 2, 2024
|
that's great! |
Merged
giordano
added a commit
to giordano/BinaryBuilderBase.jl
that referenced
this pull request
Apr 3, 2024
…essMeter This was broken by <timholy/ProgressMeter.jl#304>.
giordano
reviewed
Apr 3, 2024
Comment on lines
+102
to
+108
| function Base.setproperty!(p::T, name::Symbol, value) where T<:AbstractProgress | ||
| if hasfield(T, name) | ||
| setfield!(p, name, value) | ||
| else | ||
| setproperty!(p.core, name, value) | ||
| end | ||
| end |
There was a problem hiding this comment.
This is a breaking change, because it isn't handling automatic conversion of value to T like the default setproperty! method does: https://github.com/JuliaLang/julia/blob/a69aa30478ac9beda594235ff6f2e39549fdb752/base/Base.jl#L50-L54
giordano
added a commit
to JuliaPackaging/BinaryBuilderBase.jl
that referenced
this pull request
Apr 3, 2024
…essMeter (#373) * [Sources] Explicit conversion to work around breaking change in ProgressMeter This was broken by <timholy/ProgressMeter.jl#304>. * [CI] Do not run tests on nightly They're irremediably broken, no one is going to fix it, no point it keeping running tests bound to fail.
MarcMush
added a commit
that referenced
this pull request
Apr 3, 2024
* fix breaking setproperty! * remove pre-1.3 code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasfieldaren't defined)ProgressCorestruct to avoid duplication.