2.0: let users choose if variables+styles should be applied #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 018b24c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was
linked to
issues
May 26, 2024
LukeFinch
reviewed
May 28, 2024
| @@ -69,6 +78,8 @@ export default function ApplySelector() { | |||
|
|
|||
| <DropdownMenu.Portal> | |||
| <DropdownMenu.Content side="top"> | |||
| {/* TODO: Use DropdownMenu.Label - first add that to `ds` */} | |||
There was a problem hiding this comment.
LukeFinch
reviewed
May 28, 2024
| @@ -1,11 +1,12 @@ | |||
| import { clone } from '@figma-plugin/helpers'; | |||
|
|
|||
| export async function unbindVariableFromTarget(target: BaseNode | PaintStyle, key: 'paints' | 'fills' | 'strokes', newPaint: Paint) { | |||
There was a problem hiding this comment.
With this now, it's possible for users to completely detach a system from styles and variables - super awesome!
LukeFinch
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Closes #2618
What does this pull request do?
Gives users a choice if they want to apply styles+variables or raw values. If raw values is chosen, we will always apply raw values when applying to nodes. This effectively allows users to theme-switch even though they've created variables and styles. Before as we would always apply styles - we would not be able to react to theme changes unless the user had set up different variable modes.
Testing this change
Play around with enabling/disabling those settings and try applying various tokens to layers that have styles / variables attached.