2754 20 trying to apply a composite token that is a reference to another token fails if the referenced token comes from another set #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
six7
requested changes
May 21, 2024
| @@ -330,4 +331,4 @@ class TokenResolver { | |||
|
|
|||
| const defaultTokenResolver = new TokenResolver([]); | |||
|
|
|||
| export { defaultTokenResolver }; | |||
| export { defaultTokenResolver }; | |||
Comment on lines
+189
to
+191
| if (resolvedTokenValue.resolvedValueWithReferences) { | ||
| resolvedValueWithReferences = resolvedTokenValue.resolvedValueWithReferences; | ||
| } |
There was a problem hiding this comment.
Can you add a test case that covers this
six7
deleted the
2754-20-trying-to-apply-a-composite-token-that-is-a-reference-to-another-token-fails-if-the-referenced-token-comes-from-another-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Current plugin does not successfully affect token to figma if it has multiple level token references.
Closes #2754
What does this pull request do?
Added previous
resolvedValueWithReferencesto the token.Testing this change
Additional Notes (if any)
20240521_032431.mp4