Skip to content

Commit

Permalink
drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init
Browse files Browse the repository at this point in the history
Since drm_prime_pages_to_sg() function return error pointers.
The drm_gem_shmem_get_sg_table() function returns error pointers too.
Using IS_ERR() to check the return value to fix this.

Fixes: 2f2aa13 ("drm/virtio: move virtio_gpu_mem_entry initialization to new function")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20220602104223.54527-1-linmq006@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  • Loading branch information
Yuuoniy authored and kraxel committed Jun 9, 2022
1 parent 9e9fa6a commit c249687
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/virtio/virtgpu_object.c
Expand Up @@ -168,9 +168,9 @@ static int virtio_gpu_object_shmem_init(struct virtio_gpu_device *vgdev,
* since virtio_gpu doesn't support dma-buf import from other devices.
*/
shmem->pages = drm_gem_shmem_get_sg_table(&bo->base);
if (!shmem->pages) {
if (IS_ERR(shmem->pages)) {
drm_gem_shmem_unpin(&bo->base);
return -EINVAL;
return PTR_ERR(shmem->pages);
}

if (use_dma_api) {
Expand Down

0 comments on commit c249687

Please sign in to comment.