Skip to content

Commit

Permalink
crypto: user - fix memory leak in crypto_report
Browse files Browse the repository at this point in the history
In crypto_report, a new skb is created via nlmsg_new(). This skb should
be released if crypto_report_alg() fails.

Fixes: a38f790 ("crypto: Add userspace configuration API")
Cc: <stable@vger.kernel.org>
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Navidem authored and herbertx committed Oct 10, 2019
1 parent 64e7f85 commit ffdde59
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion crypto/crypto_user_base.c
Expand Up @@ -213,8 +213,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);

if (err)
if (err) {
kfree_skb(skb);
return err;
}

return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}
Expand Down

0 comments on commit ffdde59

Please sign in to comment.