Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-export] Bugfix query with character ':' (issue #428) #429

Merged

Conversation

waliasandeep
Copy link

…d to query name

Describe your changes

Updated the logic in selectSavedEntry function. Added an additional check that makes sure that the ":" character present is because the user added a query label and not because it is part of the query.
Also trimming the query being saved so that the new check works without any issues.
Tests scenarios checked:

Label Query
Blank SELECT Id FROM Contact WHERE LastModifiedDate = LAST_N_DAYS:10
Last 10 days query SELECT Id FROM Contact WHERE LastModifiedDate = LAST_N_DAYS:10
Blank SELECT Id FROM Account LIMIT 10
Date Literal Query SELECT Name, LastModifiedDate FROM Account WHERE LastModifiedDate > 2016-05-01T00:00:00Z

Issue ticket number and link : #428

Checklist before requesting a review

  • I have read and understand the Contributions section
  • Target branch is releaseCandidate and not master
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

@tprouvot
Copy link
Owner

Hi @waliasandeep ,
Thanks for this PR !

Did you had a chance to check my comment on the issue mentioning the fix I was thinking of ?

@waliasandeep
Copy link
Author

Hi @tprouvot !

Yes I did, while I do understand the first pointer that you have mentioned and can update this PR as per that. I might require more details regarding the second and third pointer.

@tprouvot tprouvot changed the title Release candidate issue#428 fix [data-export] Bugfix query with character ':' (issue #428) May 17, 2024
@tprouvot
Copy link
Owner

@waliasandeep thank you for the PR ! I also fixed the Save Query dropdown menu position

@tprouvot tprouvot merged commit 33d1fab into tprouvot:releaseCandidate May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants