New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Draft of PR to CMSSW #15
Conversation
…d MkFitSeed{Converter,Wrapper}
how does this differ from what's already in CMSSW_11_2_0_mkFit_X? |
'Reco', | ||
'RecoGlobal', | ||
], | ||
PU = [], | ||
suffix = '_trackingMkFit', | ||
offset = 0.7, | ||
) | ||
upgradeWFs['trackingMkFit'].step2 = { | ||
'--customise': 'RecoTracker/MkFit/customizeHLTIter0ToMkFit.customizeHLTIter0ToMkFit' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to include a customize function for the HLT iter0? (there is a risk for future maintenance effort given that it would be part of a runTheMatrix workflow)
|
I'm not sure this is expected. |
I wasn't clear on last Friday then :( I find it a bit more clear to provide customizations only for those iterations that we actually enable with |
IMHO, this will make the overhead for testing these "not yet enabled" iterations too high. BTW, the more recent version with cleaning by shared hit enabled already looks like pixelLessStep and tobTecStep can be enabled. |
Fair point, although I had imagined that we'd anyway use a custom branch on top of CMSSW, and that our development would continue in 11_2_0. If the private |
7643f4f
to
0b1728e
Compare
…d enable in selected iterations
0b1728e
to
4cdd739
Compare
The last two force-pushes include
|
should we have a modifier and config for |
Eventually yes. If this is wanted for Monday, I might be able to add it on Friday. I suppose we'd need new MTV plots if we enable it by default, I won't have time to do that. |
I think that it should be OK to have this for a follow up later. |
Original names were CMS-2017-HitSelectionWindows.h, CMS-2017.acc, CMS-2017.cc. Changes include - Rename files to adhere CMS' naming conventions - Adhere CMS' naming conventions - Code format - Replace global std::function object with a function - Call createCMS2017 instead of ExecTrackerInfoCreatorPlugin - Add comment on writes to global variables
4cdd739
to
1ac10d9
Compare
This PR has served its purpose |
No description provided.