Update docker implementation #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will close #11 |
|
Should I update the docker section of the |
|
@clschnei - apologies for the late reply. Please do update the docker section. I'll merge it once that's done. Thanks for working on this. |
* move pip3 comment * update CMD to use relative path
clschnei
force-pushed
the
docker/improve-compose-service
branch
from
b26971d
to
b071551
Compare
|
@tradytics Updated! Sorry it took so long, but feel free to merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to use the service locally there were some minor issues and easy ergonomic changes that could make this easy to run and develop against locally.
Changelog
dockerfiledocker-composefile defaultmakefilefor convenienceentry_point