Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dns-packet to 5.2.2 #6682

Merged
merged 1 commit into from
May 24, 2021
Merged

Update dns-packet to 5.2.2 #6682

merged 1 commit into from
May 24, 2021

Conversation

Ryan-Koch
Copy link
Contributor

@Ryan-Koch Ryan-Koch commented May 24, 2021

Description

Uses a resolution to update dns-packet to 5.2.2. This is in response to the following security advisory: https://www.npmjs.com/advisories/1745 . This is a short term fix while this issue is still open: facebook/create-react-app#11007.

Code Review Verification Steps

  • If the change is risky, it has been tested in experimental before merging.
  • Code follows the guidelines for Logging
  • The requirements listed in Querying the Database Safely have been satisfied.
  • Any new migrations/schema changes:
    • Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
    • Have been communicated to #g-database
    • Secure migrations have been tested following the instructions in our docs
  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • User facing changes have been reviewed by design.
  • Request review from a member of a different team.
  • Have the Jira acceptance criteria been met for this change?

@robot-mymove
Copy link

Warnings
⚠️ Please add the JIRA issue key to the PR title (e.g. MB-123)

Generated by 🚫 dangerJS against df6da92

Copy link
Contributor

@jenniferlynparsons jenniferlynparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions
Copy link

Bundle difference

Old size New size Diff
53.41 MB 53.41 MB 0 B (0.00%)

@Ryan-Koch Ryan-Koch merged commit 4f4cd14 into master May 24, 2021
@Ryan-Koch Ryan-Koch deleted the update-dns-packet-resolution branch May 24, 2021 22:29
@codeglider
Copy link

@Ryan-Koch Any reason not to update the rest of the libraries? There are a lot of moderate severity check fails at the moment.

@Ryan-Koch
Copy link
Contributor Author

@Ryan-Koch Any reason not to update the rest of the libraries? There are a lot of moderate severity check fails at the moment.

No reason not to go for it! I had done this small one because dangerjs was giving me an angry warning about it so I figured it was worth the quick fix in case others were getting it on PRs also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants