upgrade, add dynamic protocol and hostname support #24
Conversation
realies
force-pushed
the
master
branch
4 times, most recently
from
82aabe6
to
369ed21
Compare
…nginx, add websocket endpoint, patch frontend for dynamic ssl support, add supervisord and non-root user, trim image and update docs
There was a problem hiding this comment.
@realies Sorry for the delay in review, but I am just now getting around to this PR. Thank you for your work on this! Generally, your enhancements look good, however I am running into a couple issues.
-
Going to http://localhost:8080/ does not immedately load you into the game. It shows the "Awaiting Connection" screen and you have to ESC and then join via the Multiplayer menu:
-
After about a minute of gameplay, I am seeing a "Connection Interrupted" message. I feel like this may be related to the nginx server config:
My master branch needs a small update to Dockerfile to build, so I will make that now.
|
thanks, i did not see any reverse proxy timeouts and it worked fine on localhost afaik |
|
Nice work, but I take it it's not possible to use this if you are already running a reverse proxy? Two instances of nginx is not gonna work, or am I missing something? Edit: Nevermind, worked perfectly. I suppose the internal nginx service is hidden from the rest of the containers. Awesome job :D |
fixes #12 and #4