Added button for MapCreator launch | Some workarounds(#843) #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -372,6 +377,14 @@ private void setupListeners() { | |||
| ProcessRunnerUtil.exec(commands); | |||
|
|
|||
| })); | |||
| m_mapXmlCreator.addActionListener(SwingAction.of("[Beta] Run the Map Creator", e -> { | |||
| final List<String> commands = new ArrayList<>(); | |||
There was a problem hiding this comment.
DRY violation.
Can use a helper method to return a Runnable that takes in 'javaClass' as a parameter
|
@DanVanAtta fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adresses #843.
Please note, that I removed this do-while loop (why the heck is this even used?!) In order to enable the user to close the map creator once he accidentally opened it without the need to select a file or to kill the process.
This is only a quick workaround...
The future task would be to close the JFileChooser, once the user selects cancel
This change is