NAS-128399 / 24.10 / More nfs failover fixes #13598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix flake8 complaint. Improve error reporting for service state check.
…about 5 sec to start. Added check for NFS dataset in first boot check in test_001_ssh.py. Some simple refactoring in test_300_nfs.py.
bugclerk
changed the title
anodos325
reviewed
Apr 19, 2024
anodos325
reviewed
Apr 19, 2024
yocalebo
requested changes
Apr 19, 2024
anodos325
reviewed
Apr 22, 2024
yocalebo
reviewed
Apr 22, 2024
yocalebo
requested changes
Apr 24, 2024
* Rename class NFSPath to NFSServicePathInfo and fixup usage in status.py and local.conf.mako * Move improved name_to_id_conversion to standalone private method * Update NFS state directory initialization
yocalebo
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Fantastic, great job! Glad to see this general issue get resolved, finally. Be sure and wait for @anodos325 before merge 👍
yocalebo
reviewed
Apr 24, 2024
anodos325
approved these changes
Apr 26, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
NFS was not configured to properly support HA function. NFS holds client state information in a database that, by default, is located at /var/lib/nfs. To properly support failover we need that to be a shared directory. For TrueNAS that is the system dataset.
Fix
Create and NFS entry in the system dataset. Generate the necessary directory structure and to support upgrade we also initialize it with data from /var/lib/nfs.
In systemd we bind the NFS client tracking daemon to nfs-server to allow the transfer of the client tracking database.
Update the nfs configuration file with the path to the nfs data on the system dataset:
/var/db/system/nfsOther related items in the PR