NAS-128546 / 24.10 / Improvements requested by UI team for new enclosure.dashboard #13622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI team is currently implementing the changes required to consume
webui.enclosure.dashboard
but they're missing some key items that make it awkward to deal with on their side. This does 3 primary things:drive_bay_number
key towebui.enclosure.dashboard
drive_bay_number
andid
keys todisk.get_unused
device.get_disks
indisk.get_unused
instead of querying the disk table. The reason why we don't query the database table is because we have seen various edge-cases where disks are updated in kernel but our database doesn't get updated. This is hard to predict and is even harder to properly handle. The kernel already "caches" the disk info that we need sodevice.get_disks
goes directly to the source of truth. This method has been optimized tremendously and has been proven to perform tolerably compared to querying the db.