NAS-128628 / 24.10 / Add search elements for Application

[bvasilenko]

Testing

See ticket

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128628

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 74.00%. Comparing base (c4eec1d) to head (f595969).

Files	Patch %	Lines
...ponents/installed-apps/installed-apps.component.ts	0.00%	13 Missing ⚠️
...-search-results/global-search-results.component.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10021      +/-   ##
==========================================
- Coverage   74.01%   74.00%   -0.01%     
==========================================
  Files        1549     1550       +1     
  Lines       54048    54059      +11     
  Branches     6475     6476       +1     
==========================================
+ Hits        40002    40007       +5     
- Misses      14046    14052       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AlexKarpov98]

Looks good.
Only missing a few search items:

I can't search for "Custom App" right now

I can't search for "Add Catalog" right now

[AlexKarpov98]

@bvasilenko - you didn't fix what I mentioned earlier, you just pulled from master?

[AlexKarpov98]

As well there is an issue with apps screen:
Seems like it's redenders and hides searched elements because of it.

Screen.Recording.2024-05-17.at.08.45.30.mov

[AlexKarpov98]

It works now, thanks 👍