Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128795 / 24.10 / Various improvements for global search #10039

Merged
merged 4 commits into from May 13, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket
Screenshot 2024-05-08 at 12 59 17

@AlexKarpov98 AlexKarpov98 self-assigned this May 8, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner May 8, 2024 09:59
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team May 8, 2024 09:59
@bugclerk bugclerk changed the title NAS-128795: Various improvements for global search NAS-128795 / 24.10 / Various improvements for global search May 8, 2024
@bugclerk
Copy link
Contributor

bugclerk commented May 8, 2024

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.68%. Comparing base (508b25f) to head (1d0100b).
Report is 9 commits behind head on master.

Files Patch % Lines
...omponents/global-search/global-search.component.ts 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10039      +/-   ##
==========================================
+ Coverage   73.62%   73.68%   +0.05%     
==========================================
  Files        1513     1512       -1     
  Lines       52820    53043     +223     
  Branches     6307     6341      +34     
==========================================
+ Hits        38890    39083     +193     
- Misses      13930    13960      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder not updating when input isn't in focus

Screen.Recording.2024-05-10.at.5.37.50.PM.mov

@AlexKarpov98 AlexKarpov98 merged commit fea96e0 into master May 13, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128795 branch May 13, 2024 06:22
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants