Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include pages based on a tag #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

byronwilliams
Copy link

Change Summary

  • Include pages for a collection by the use of a tag selector

PR Checklist

resolve: `gatsby-plugin-typesense`,
options: {
rootDir: `${__dirname}/public`, // Required
includeTags: { "data-typesense-model": "product" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word includeTags almost makes it sound like these are the only tags that will be indexed by the plugin. How about calling it something like includePagesWithTags.

Also, I know the tag name here is just an example, but it makes it sound like it configures the Typesense Collection that the page is indexed to. How about we have the example as:

includePagesWithTags: {"data-typesense-include-page": "product"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants