Link to FIDO web page not zip file #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link to FIDO triggers a zip file download Signed-off-by: Michiel de Jong <michiel@unhosted.org>
michielbdejong
requested review from
expede,
matheus23,
Gozala and
dholms
as code owners
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @michielbdejong on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
|
Where can I sign your CLA? |
|
Thank for the PR @michielbdejong 🙏 The signing process is described in the contribution guidelines: https://github.com/ucan-wg/spec/blob/main/CONTRIBUTING.md#pull-request-process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to FIDO triggers a zip file download, maybe better to link to a web page?
This one does show up a sign-up modal as soon as you visit, maybe there are better pages to link to.