Refactor the contact form to use React Router #6504
Draft
+204
−408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #51009 ↗︎
Details:
Review all test suite changes for PR #6504 ↗︎ |
|||||||||||||||
paulgain
force-pushed
the
refactor/contact-form-to-use-react-router
branch
from
365b1f7
to
94fd358
Compare
When filling out a form and then redirecting to add a contact we want to persist the previous form's state so when we save the contact and return to the form its state is maintained. This new approach means we no longer have to write to window.sessionStorage to save the form state and then read from it after saving the contact. All of this is made possible by using react-router, a soft redirect compared to the current hard redirect which sets window.location.href.
paulgain
force-pushed
the
refactor/contact-form-to-use-react-router
branch
from
94fd358
to
9c396de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Refactor the contact form to use React Router.
Checklist