Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for parameters for metadata API calls #6801

Merged
merged 3 commits into from
May 23, 2024
Merged

Allow for parameters for metadata API calls #6801

merged 3 commits into from
May 23, 2024

Conversation

DeanElliott96
Copy link
Contributor

@DeanElliott96 DeanElliott96 commented May 16, 2024 •
edited

Description of change

Related to a similar PR: https://github.com/uktrade/data-hub-frontend/pull/6759/files

Fixes loading of investments on a company page.

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@DeanElliott96 DeanElliott96 self-assigned this May 16, 2024
@DeanElliott96 DeanElliott96 requested a review from a team as a code owner May 16, 2024 10:09
@cypress Cypress
Copy link

cypress bot commented May 16, 2024 •
edited

Passing run #53570 ↗︎

0 74 3 0 Flakiness 0

Details:

Update incorrect URL in urlExclusions
Project: data-hub-frontend Commit: e766a11d02
Status: Passed Duration: 09:01 💡
Started: May 23, 2024 9:13 AM Ended: May 23, 2024 9:22 AM

Review all test suite changes for PR #6801 ↗︎

oliverjwroberts
oliverjwroberts approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@oliverjwroberts oliverjwroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR standardises API endpoints used for retrieving large capital opportunity details and metadata on a company page. This also addresses the bug when retrieving metadata on the new DBT platform.

Looks good to me 👍🏻

@DeanElliott96 DeanElliott96 merged commit 8a35821 into migration-deploy May 23, 2024
14 checks passed
@DeanElliott96 DeanElliott96 deleted the bugfix/TET-733-investments branch May 23, 2024 10:03
@cypress cypress bot mentioned this pull request May 23, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p3dr0migue1 p3dr0migue1 p3dr0migue1 approved these changes

@bau123 bau123 bau123 approved these changes

@oliverjwroberts oliverjwroberts oliverjwroberts approved these changes

Assignees

@DeanElliott96 DeanElliott96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DeanElliott96 @p3dr0migue1 @bau123 @oliverjwroberts