Refactor events collection to call the API rather than ActivityStream #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #53403 ↗︎
Details:
Review all test suite changes for PR #6802 ↗︎ |
|||||||||||||||
cgsunkel
force-pushed
the
migration-deploy
branch
from
a988ea8
to
3d2553a
Compare
…as in activity cards
cgsunkel
force-pushed
the
chore/remove-activity-stream-from-events-collection
branch
2 times, most recently
from
dd6afbf
to
95dce95
Compare
cgsunkel
force-pushed
the
chore/remove-activity-stream-from-events-collection
branch
from
62cf1fd
to
1dcb08b
Compare
paulgain
approved these changes
May 20, 2024
3 tasks
marijnkampf
pushed a commit
that referenced
this pull request
May 23, 2024
* Refactor CollectionItem to allow tags to be rendered in the same way as in activity cards * Refactor events collection page to use the API instead of ActivityStream * Update tests * Cleanup dead code
cgsunkel
added a commit
that referenced
this pull request
Jun 3, 2024
* Refactor CollectionItem to allow tags to be rendered in the same way as in activity cards * Refactor events collection page to use the API instead of ActivityStream * Update tests * Cleanup dead code
cgsunkel
added a commit
that referenced
this pull request
Jun 3, 2024
* Refactor CollectionItem to allow tags to be rendered in the same way as in activity cards * Refactor events collection page to use the API instead of ActivityStream * Update tests * Cleanup dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Our various integrations with ActivityStream no longer work on the new DBT platform, which leaves a couple of key pages unusable. As we are about to start testing these new environments with users, we need to ensure that all key pages are error-free. As ActivityStream is going to be retired in the next couple of months we need to replace these integrations anyway, however we won't be able to do this work before user testing starts. Therefore the decision has been made to remove these integrations.
The first integration to be removed is the Events collection list. Whilst doing this work I have replaced the long lists of checkboxes with typeaheads.
Test instructions
The events CollectionList should only display Data Hub events, and contain no references to Aventri. Everything else should work as before.
Checklist