feat(smart-contracts): UP token contract #13875
Conversation
| __GovernorTimelockControl_init(_timelock); | ||
|
|
||
| // default quorum set to 30k | ||
| _quorum = 30000e18; |
| TimelockControllerUpgradeable _timelock | ||
| ) public initializer { | ||
| __Governor_init("UnlockProtocolGovernor"); | ||
| __GovernorSettings_init(43200 /* 6 day */, 43200 /* 6 days */, 0); |
There was a problem hiding this comment.
Is this in seconds? If so this is not 6 days! please use 6* 24 * 60 * 60 for clarty.
| @@ -12,15 +12,15 @@ const { getEvent } = require('@unlock-protocol/hardhat-helpers') | |||
|
|
|||
| const PROPOSER_ROLE = ethers.keccak256(ethers.toUtf8Bytes('PROPOSER_ROLE')) | |||
|
|
|||
| describe('UnlockProtocolGovernor', () => { | |||
| // default values | |||
| const SIX_DAYS = 43200 // in blocks | |||
There was a problem hiding this comment.
hum, I think we should not use blocks because that's different based on what chain we go for. Can we use seconds rather?
There was a problem hiding this comment.
Just moved the gov and erc20 votes to use timestamps instead of blocks
Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
| // default quorum set to 3000 | ||
| _quorum = 3000e18; | ||
| } |
There was a problem hiding this comment.
use GovernorVotesQuorumFraction instead
There was a problem hiding this comment.
ok added relative quorum
|
Here the entire UP supply has been transferred to the Swap contract on creation https://sepolia.basescan.org/tx/0x0e7f60f86a244b68101267d606354816b5fb42f871f640c207f609c4b8740d82 |
| _mint(preMinter, TOTAL_SUPPLY * 10 ** decimals()); | ||
| } | ||
|
|
||
| // required to base votes on timestamp instead of blocks |
Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
|
Governor is there https://www.tally.xyz/gov/up-token-base-sepolia-test-dao |
Description
This PR adds the UnlockDiscountToken ERC20 contract
Need to rebase once #13874 s mergedIssues
Fixes #
Refs #
Checklist:
Release Note Draft Snippet