Add WinAppSdk Trimming support #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
approved these changes
Sep 18, 2023
|
I think publishtrimmed should be in the publish XML files. |
nickrandolph
requested changes
Sep 19, 2023
There was a problem hiding this comment.
PublishTrimmed should either be here or in the .pubxml files. Also not sure whether there's still work to be done to ensure trimming works for Uno apps (see microsoft/CsWinRT#373)
nickrandolph
approved these changes
Sep 19, 2023
nickrandolph
force-pushed
the
dev/ds/winappsdk-trimming
branch
from
f550c9c
to
8fc871e
Compare
|
@mergify backport legacy/4x release/stable/4.10 |
✅ Backports have been created
|
This was referenced Sep 20, 2023
nickrandolph
added a commit
that referenced
this pull request
Sep 20, 2023
Add WinAppSdk Trimming support (backport #298)
nickrandolph
added a commit
that referenced
this pull request
Sep 20, 2023
…10/pr-298 Add WinAppSdk Trimming support (backport #298)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
WinAppSdk trimming is not enabled
What is the new behavior?
WinAppSdk trimming is enabled