Skip to content

Commit

Permalink
Add the -q option to the ssh-keygen cmd
Browse files Browse the repository at this point in the history
Add the `-q` option to the ssh-keygen cmd to silence it so we don't see
the output informing us that we are "Signing data on standard input".
This doesn't match 100% with the way that Git proper is calling this
command anymore, because they don't use the `-q` option. Instead they
seem to execute the program ignoring it's standard output. Which maybe
we should do to make the interface match exactly the same. That way
other applications don't have to implement the `-q` switch that are
trying to standin, like the 1Password ssh key one.

<!-- ps-id: e9fcc740-16c6-4818-910d-8913ad58bdf0 -->
  • Loading branch information
drewdeponte committed Feb 29, 2024
1 parent e5c95f0 commit 08b0ce6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ps/private/git/signers/ssh_signer.rs
Expand Up @@ -65,7 +65,7 @@ fn ssh_sign_string(
let output = utils::execute_with_input_and_output(
&commit,
&prog,
&["-Y", "sign", "-n", "git", "-f", path],
&["-Y", "sign", "-n", "git", "-q", "-f", path],
)
.map_err(|e| SshSignStringError::Unhandled(e.into()))?;

Expand Down

0 comments on commit 08b0ce6

Please sign in to comment.