Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework maven code for faster calculation of path config #1661

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DavyLandman
Copy link
Member

@DavyLandman DavyLandman commented Oct 3, 2022

This needs effort to make this work together with our shaded jars.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1661 (f574853) into main (4995464) will increase coverage by 0%.
The diff coverage is 0%.

@@           Coverage Diff           @@
##              main   #1661   +/-   ##
=======================================
  Coverage       48%     48%           
- Complexity    5928    5932    +4     
=======================================
  Files          676     676           
  Lines        58597   58599    +2     
  Branches      8533    8533           
=======================================
+ Hits         28299   28305    +6     
+ Misses       28167   28160    -7     
- Partials      2131    2134    +3     
Impacted Files Coverage Δ
src/org/rascalmpl/library/util/PathConfig.java 0% <0%> (ø)
...calmpl/interpreter/result/SetOrRelationResult.java 82% <0%> (-9%) ⬇️
...almpl/interpreter/result/ListOrRelationResult.java 62% <0%> (-6%) ⬇️
...c/org/rascalmpl/interpreter/result/NodeResult.java 66% <0%> (-3%) ⬇️
.../org/rascalmpl/interpreter/result/TupleResult.java 67% <0%> (-2%) ⬇️
...g/rascalmpl/interpreter/result/DateTimeResult.java 15% <0%> (-1%) ⬇️
src/org/rascalmpl/interpreter/result/Result.java 13% <0%> (-1%) ⬇️
src/org/rascalmpl/library/Prelude.java 43% <0%> (+<1%) ⬆️
.../org/rascalmpl/interpreter/TraversalEvaluator.java 90% <0%> (+1%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

On windows increases speed from 14s to 2s
…y, changing output streams, hoping it's not a race)
@jurgenvinju
Copy link
Member

The idea would be to turn this PR into a general utility/service for Maven-related features for Rascal:

  • dependency resolution
  • exploration and install of new components in the REPL/IDE

Davy's setup allows for a lean and fast application of maven features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants