USWDS - Update tool-versions file with current Node LTS version #5932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyleadem
changed the title
amyleadem
changed the title
mejiaj
approved these changes
May 17, 2024
|
I wasn't able to reproduce the original issue. No issues found with installing with node |
thisisdano
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the listed Node version in
.tool-versionsto the current LTS version, 20.13.1. Updating to this version from 20.9.0 resolves aMaxListenersExceededwarning duringnpm install.Breaking change
This is not a breaking change.
Related issue
Closes #5927
Related pull requests
N/A - No changelog because it is not a user facing change
Preview link
N/A
Problem statement
USWDS currently specifies Node version 20.9.0 in its
.tool-versionsfile. We encountered the following warnings duringnpm installwhen using node v20.9.0:Updating to the current node LTS version (20.13.1) resolves this warning. We should update
tool-versionsto use this version of Node instead.Testing and review