Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys: rm SAN hack including 0 etcd host in all certs #107

Merged
merged 1 commit into from
Mar 3, 2020
Merged

sys: rm SAN hack including 0 etcd host in all certs #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions etcd.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,7 @@ data "template_file" "etcd-cfssl-new-cert" {
org = ""
get_ip = var.get_ip_command[var.cloud_provider]
get_hostname = var.node_name_command[var.cloud_provider]
# workaround for https://github.com/kubernetes/kubernetes/issues/72102
# include first member's ip in SAN for all nodes
# this replicates kubeadm behaviour to include first node's ip, as kubeadm
# generates all certificates on the first node
extra_names = join(",", ["etcd.${var.dns_domain}", var.etcd_addresses[0]])
extra_names = join(",", ["etcd.${var.dns_domain}"])
}
}

Expand Down