Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize labels and titles #619

Closed
wants to merge 15 commits into from
Closed

Sanitize labels and titles #619

wants to merge 15 commits into from

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Aug 5, 2021

Workaround for: highcharts/highcharts#13559
See also: SNYK-JS-HIGHCHARTS-571995

There is no newer version in Highcharts 4 series than curently used. Thus sanitizing in Vaadin add-on isntead of updating library.

Workaround for: highcharts/highcharts#13559
See also: SNYK-JS-HIGHCHARTS-571995

There is no newer version in Highcharts 4 series than curently used. Thus sanitizing in Vaadin add-on isntead of updating library.
Copy link
Member

@Legioth Legioth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the test?

TatuLund added a commit to TatuLund/charts that referenced this pull request Aug 5, 2021
WIP: Testing if Javascript workaround provided Highcharts still works with old Highcharts

This alternative to vaadin#619
@TatuLund
Copy link
Contributor Author

TatuLund commented Aug 5, 2021

Closed in favor of #621

@TatuLund TatuLund closed this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants