Provide AsyncFileStreaming API #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The stream file functions could use some tidying up as there's a lot of duplicated code there |
…ams while cascading errors thrown from the stream callback to the promise.
…nnelResponseBodyStream
… (in which assertions like the one in ChannelResponseBodyStream's deinit aren't checked).
…ase even if trying to write the error indication to the stream fails
…atomics, and to handle errors and the promise completions more consistently. Especially affects async streaming, but eliminates error handling issues in non-async streaming as well.
This reverts commit c98f0bf.
Co-authored-by: Gwynne Raskind <gwynne@vapor.codes>
gwynne
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.97.0
Builds on the work of #2998, #3170 and #3167 to provide a full async streaming API that can be used in Swift Concurrency environments:
asyncStreamFile(at:chunkSize:mediaType:advancedETagComparison:onCompleted:)that takes advantage of the full async response streamingFileMiddlewareis now anAsyncMiddlewareFileManagerwithNIOFileSystemapart from in one deprecated API that can't be asyncXCTVaporfunctions asnoasyncwhere they use.wait()and provides proper async alternatives