Add Async Storage shutdown #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
approved these changes
May 21, 2024
Comment on lines
14
to
28
| var onAsyncShutdown: (@Sendable (T) async throws -> ())? | ||
| func shutdown(logger: Logger) { | ||
| do { | ||
| try self.onShutdown?(self.value) | ||
| } catch { | ||
| logger.warning("Could not shutdown \(T.self): \(error)") | ||
| } | ||
| } | ||
| func asyncShutdown(logger: Logger) async { | ||
| do { | ||
| try await self.onAsyncShutdown?(self.value) | ||
| } catch { | ||
| logger.warning("Could not shutdown \(T.self): \(error)") | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't have a better suggestion, but this seems incredibly error-prone/easy to misuse 😕
0xTim
commented
May 21, 2024
| public var asyncShared: HTTPClient { | ||
| get async { | ||
| let lock = self.application.locks.lock(for: Key.self) | ||
| lock.lock() |
There was a problem hiding this comment.
This makes me uneasy but I don't see a way around it - any thoughts?
Co-authored-by: Gwynne Raskind <gwynne@vapor.codes>
|
Ok @gwynne I've tested this with client calls as well and think I've fixed all the different areas without breaking the API too much |
gwynne
approved these changes
May 24, 2024
0xTim
added
semver-minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.101.0
Currently running
When you try and install NIO as the global executor will crash because the storage API didn't have any async entry points so stopping would trigger a synchronous shutdown, with a
wait(). This fixes that