-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(packages/ui turbo gen config.ts): Preventing the format of pack… #8033
Conversation
…age.json from being corrupted
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@moeyashi is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Hi, thanks for the contribution! Can you explain a little more about the nature of the "corruption" this PR is meant to solve? |
Thank you for your review. I edited this issue to explain what this PR is trying to solve. "corrupted" may not be a good expression. "broken", "incorrect" and "wrong" are candidates. |
Just so I'm clear on what I'm seeing here: There's a missing tab character when the generator is run? |
Yes, there's a missing tab character. But my fix is to indent with 4 spaces instead of a tab character. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Thanks!
…age.json from being corrupted
Description
Prevent the format of
package.json
from getting corrupted when creating a component withturbo gen
.Here's what the exports section looks like before and after the fix:
before
after
Testing Instructions
turbo gen
.