feat(examples): add example-with-angular
#8140
Open
+64,490
−4,627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
area: ci
area: examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
|
@codexshell is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
codexshell
force-pushed
the
example/with-angular
branch
3 times, most recently
from
9b23d4d
to
cd0a6a6
Compare
A new example template utilizing Angular has been added to the 'examples' directory. This template serves as a reference implementation for projects looking to integrate Angular with the turbo repo ecosystem.
codexshell
force-pushed
the
example/with-angular
branch
from
cd0a6a6
to
550a130
Compare
arlyon
approved these changes
May 21, 2024
anthonyshew
requested changes
Jun 16, 2024
anthonyshew
requested changes
Jun 16, 2024
| { | ||
| "$schema": "https://turbo.build/schema.json", | ||
| "globalDependencies": ["**/.env.*local"], | ||
| "pipeline": { |
There was a problem hiding this comment.
Run npx @turbo/codemod upgrade to upgrade to turbo@2. 🥳
| "@repo/eslint-config": "workspace:*", | ||
| "eslint": "^8.57.0", | ||
| "prettier": "^2.8.8", | ||
| "turbo": "^1.13.3" |
There was a problem hiding this comment.
Run npx @turbo/codemod upgrade to upgrade to turbo@2. 🥳
|
|
||
| /** @type {import("eslint").Linter.Config} */ | ||
| module.exports = { | ||
| extends: ['eslint:recommended', 'prettier', 'eslint-config-turbo'], |
There was a problem hiding this comment.
Suggested change
| extends: ['eslint:recommended', 'prettier', 'eslint-config-turbo'], | |
| extends: ['eslint:recommended', 'prettier', 'turbo'], |
This should be only turbo instead of eslint-config-turbo. This was a bug we had in the rest of the examples, so don't blame you for following what we did.
Make sure to run the turbo run lint command to make sure it runs successfully!
There was a problem hiding this comment.
All requested changes will be ready before Monday. Starting work on them
anthonyshew
reviewed
Jun 16, 2024
| "@typescript-eslint/eslint-plugin": "^7.9.0", | ||
| "@typescript-eslint/parser": "^7.9.0", | ||
| "eslint-config-prettier": "^9.1.0", | ||
| "eslint-config-turbo": "^1.13.3", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new example template utilizing Angular has been added to the
examplesdirectory.This template serves as a reference implementation for projects looking to integrate Angular with the turbo repo ecosystem.
Screenshots
Testing Instructions