-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use prehash to avoid rehashing the key in the task cache #8174
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
Logs
See job summary for details |
🟢 CI likely successful 🟢A few longer running steps are still running, but they should not be considered as blocking. See workflow summary for details |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
### Description In this PR #8174 the library prehash is licensed using MPL2.0 (great) but without the copyleft exception. I believe that we are OK. From what I understand this prevents us from making and redistributing changes to this library under one of the MPL secondary licenses ("Secondary License" means either the GNU General Public License, Version 2.0, the GNU Lesser General Public License, Version 2.1, the GNU Affero General Public License, Version 3.0, or any later versions of those licenses). It does not exclude us from using that library in a 'larger work' that is licensed using a different (compatible) license so for the purpose of distributing a binary it is the same as MPL-2.0 ### Testing Instructions N/A
See my comment here: #8194 (review) I don't think this library is providing much value, and we could easily implement this ourselves, which might avoid the mess with the extra MPL license variant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a fair bit of license palava, replacing with https://app.graphite.dev/github/pr/vercel/turbo/8262/add-crate-to-calculate-prehashes
c6c969d
to
334f637
Compare
Description
This avoids hashing the task type multiple times, e. g. for inserting after lookup or on rehashing of the hash map
Testing Instructions