-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed redundant @storybook/addon-docs dev dependency #8184
Open
NickE27
wants to merge
3
commits into
vercel:main
Choose a base branch
from
NickE27:nicke27/remove-storybook-addon-docs-from-design-system-example
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Removed redundant @storybook/addon-docs dev dependency #8184
NickE27
wants to merge
3
commits into
vercel:main
from
NickE27:nicke27/remove-storybook-addon-docs-from-design-system-example
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h addon-essentials.
turbo-orchestrator
bot
added
area: examples
Improvements or additions to examples
needs: triage
New issues get this label. Remove it after triage
owned-by: turborepo
labels
May 21, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Someone is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
…ign-system-example
…ign-system-example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: examples
Improvements or additions to examples
needs: triage
New issues get this label. Remove it after triage
owned-by: turborepo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@storybook/addon-docs was included as a dev dependency, and imported into the config. This is now part of addon-essentials and therefore it's inclusion here is redundant.
With addon-docs as a separate, additional dependency, storybook would throw
TypeError: Failed to fetch dynamically imported module
when importing mdx files, making it impossible to add custom documentation.