Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant @storybook/addon-docs dev dependency #8184

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NickE27
Copy link

@NickE27 NickE27 commented May 21, 2024

@storybook/addon-docs was included as a dev dependency, and imported into the config. This is now part of addon-essentials and therefore it's inclusion here is redundant.

With addon-docs as a separate, additional dependency, storybook would throw TypeError: Failed to fetch dynamically imported module when importing mdx files, making it impossible to add custom documentation.

@NickE27 NickE27 requested review from anthonyshew and a team as code owners May 21, 2024 11:10
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels May 21, 2024
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ❌ Failed (Inspect) Jun 5, 2024 9:08am
examples-designsystem-docs ❌ Failed (Inspect) Jun 5, 2024 9:08am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 9:08am
examples-native-web ❌ Failed (Inspect) Jun 5, 2024 9:08am
examples-svelte-web ❌ Failed (Inspect) Jun 5, 2024 9:08am
examples-tailwind-web ❌ Failed (Inspect) Jun 5, 2024 9:08am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 9:08am

Copy link

vercel bot commented May 21, 2024

Someone is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant