Fix for plugins returning DONE from HELO/EHLO

We have to return something true, else the client gets an additional 451 Internal error - try again later - command 'helo' failed unexpectedly after the plugin's ->respond() message.
vetinari · Mar 11, 2009 · 25b5cef · 25b5cef
1 parent 6b14b38
commit 25b5cef
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/Qpsmtpd/SMTP.pm b/lib/Qpsmtpd/SMTP.pm
@@ -162,7 +162,8 @@ sub helo_respond {
   my ($self, $rc, $msg, $args) = @_;
   my ($hello_host) = @$args;
   if ($rc == DONE) {
-    # do nothing
+    # do nothing:
+    1;
   } elsif ($rc == DENY) {
     $self->respond(550, @$msg);
   } elsif ($rc == DENYSOFT) {
@@ -198,7 +199,8 @@ sub ehlo_respond {
   my ($self, $rc, $msg, $args) = @_;
   my ($hello_host) = @$args;
   if ($rc == DONE) {
-    # do nothing
+    # do nothing:
+    1; 
   } elsif ($rc == DENY) {
     $self->respond(550, @$msg);
   } elsif ($rc == DENYSOFT) {