Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-2808: Use weak deps in transform camera #3646

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hexbabe
Copy link
Member

@hexbabe hexbabe commented Mar 4, 2024

https://viam.atlassian.net/browse/RSDK-2808

Tested detections locally and works
Screenshot 2024-03-04 at 4 02 01 PM

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Mar 4, 2024
@hexbabe hexbabe changed the title RSDK-2808: Remove deprecated constructor and robot object in favor of weak deps RSDK-2808: Use weak deps in transform camera Mar 4, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 4, 2024
@hexbabe
Copy link
Member Author

hexbabe commented Mar 7, 2024

local_robot.go:771: 2024-03-05T00:15:06.465Z ERROR impl/local_robot.go:771 failed to reconfigure resource during weak dependencies update {"resource":"rdk:component:camera/color_detect","error":"cannot reconfigure \"rdk:component:camera/color_detect\"; must rebuild"}

Errors such as the above in tests should be resolved once https://viam.atlassian.net/browse/RSDK-6845 is in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
2 participants