-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-7555 remove ErrorState method from KinematicBase interface #3965
base: main
Are you sure you want to change the base?
Conversation
@@ -203,7 +199,7 @@ func WrapWithFakePTGKinematics( | |||
} | |||
ptgs := ptgProv.PTGSolvers() | |||
traj := motionplan.Trajectory{{frame.Name(): zeroInput}} | |||
path := motionplan.Path{{frame.Name(): referenceframe.NewPoseInFrame(origin.Parent(), spatialmath.Compose(origin.Pose(), sensorNoise))}} | |||
path := motionplan.Path{{frame.Name(): origin}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we no longer want to consider sensor noise for fake mockups?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think with this change we are applying the same sensor noise twice, since it is also applied in the Localizer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending tests passing
Availability
Quality
Performance
The above data was generated by running scenes defined in the
|
No description provided.