RSDK-7677 Update Analog reader RC card #3975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviamiller
requested review from
ethanlook,
micheal-parks and
DTCurrie
as code owners
viambot
added
the
safe to test
DTCurrie
reviewed
May 20, 2024
viambot
added
safe to test
ethanlook
approved these changes
May 21, 2024
| @@ -95,7 +95,7 @@ const writeAnalog = async () => { | |||
|
|
|||
| const readAnalog = async () => { | |||
| try { | |||
| const value = await boardClient.readAnalogReader(analogPinName); | |||
| const {value} = await boardClient.readAnalogReader(analogPinName); | |||
There was a problem hiding this comment.
This should resolve your lint error!
Suggested change
| const {value} = await boardClient.readAnalogReader(analogPinName); | |
| const { value } = await boardClient.readAnalogReader(analogPinName); |
There was a problem hiding this comment.
i'm pretty sure the lint error is because rdk doesn't point to the new typescript changes yet so it still thinks the return value is a number? im waiting to merge this until next TS release. But can still change to this syntax if preferred.
There was a problem hiding this comment.
Ah that's certainly the case as well, I think you'll start getting this error once the TS release is resolved. Either way, this spacing looks a little nicer to me. Thanks!
viambot
added
safe to test
|
closing, being done in https://github.com/viamrobotics/rdk/pull/3994 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
board
readAnalogReaderresponse type was changed to a struct so we need to callvalueto get the bit value for the RC card.This relies on the typescipt change so will be waiting to merge this until the updated typescript sdk version is being used by RDK.
Tested locally with a fake board.