Use ruff to lint/format/isort #476
Open
+27,450
−11,149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 72a9871.
maximpertsov
commented
Nov 1, 2023
src/viam/app/app_client.py
Outdated
There was a problem hiding this comment.
I couldn't get this one in parity, but might be fine?
maximpertsov
commented
Nov 1, 2023
| @@ -33,7 +33,7 @@ class ResourceCreatorRegistration: | |||
| """A function that can create a resource given a mapping of dependencies (``ResourceName`` to ``ResourceBase`` | |||
| """ | |||
|
|
|||
| validator: "Validator" = lambda x: [] | |||
| validator: "Validator" = lambda x: [] # noqa: E731 | |||
There was a problem hiding this comment.
also wasn't able to figure this one out
maximpertsov
requested review from
purplenicole730,
cheukt and
njooma
and removed request for
purplenicole730 and
cheukt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.