added capablties to webdirver session

viant · Apr 25, 2024 · c194250 · c194250
1 parent c745708
commit c194250
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 12 deletions.
diff --git a/service/testing/runner/webdriver/contract.go b/service/testing/runner/webdriver/contract.go
@@ -24,11 +24,12 @@ const (
 
 // StartRequest represents a selenium server start request
 type StartRequest struct {
-	Target *location.Resource
-	Driver string
-	Server string
-	Sdk    string
-	Port   int
+	Target       *location.Resource
+	Driver       string
+	Server       string
+	Sdk          string
+	Capabilities []string
+	Port         int
 }
 
 func (r *StartRequest) Init() error {

diff --git a/service/testing/runner/webdriver/service.go b/service/testing/runner/webdriver/service.go
@@ -472,9 +472,9 @@ func (s *service) start(context *endly.Context, request *StartRequest) (*StartRe
 		session = &Session{SessionID: sessionID}
 		sessions[sessionID] = session
 	}
-
 	useSelenium := request.Server != ""
 	if !useSelenium {
+		session.Capabilities = request.Capabilities
 		switch request.Driver {
 		case ChromeDriver:
 			if session.service, err = selenium.NewChromeDriverService(response.DriverPath, request.Port); err != nil {
@@ -550,6 +550,9 @@ func (s *service) openSession(context *endly.Context, request *OpenSessionReques
 
 	caps := selenium.Capabilities{}
 	if session.Pid == 0 {
+		if len(session.Capabilities) > 0 && len(request.Capabilities) == 0 {
+			request.Capabilities = session.Capabilities
+		}
 		switch session.Browser {
 		case ChromeBrowser:
 			caps.AddChrome(chrome.Capabilities{Args: request.Capabilities})

diff --git a/service/testing/runner/webdriver/session.go b/service/testing/runner/webdriver/session.go
@@ -7,12 +7,13 @@ import (
 
 // Session represents a selenium session
 type Session struct {
-	SessionID string
-	Browser   string
-	Pid       int
-	Server    string
-	driver    selenium.WebDriver
-	service   *selenium.Service
+	SessionID    string
+	Browser      string
+	Pid          int
+	Server       string
+	driver       selenium.WebDriver
+	service      *selenium.Service
+	Capabilities []string
 }
 
 func (s Session) Close() {