Skip to content

Commit

Permalink
patch 8.2.4955: text property in wrong position after auto-indent
Browse files Browse the repository at this point in the history
Problem:    Text property in wrong position after auto-indent.
Solution:   Adjust text property columns. (closes #10422, closes #7719)
  • Loading branch information
LemonBoy authored and brammool committed May 14, 2022
1 parent 698cb4c commit 788c06a
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 3 deletions.
13 changes: 10 additions & 3 deletions src/change.c
Expand Up @@ -1372,7 +1372,8 @@ open_line(
char_u *next_line = NULL; // copy of the next line
char_u *p_extra = NULL; // what goes to next line
int less_cols = 0; // less columns for mark in new line
int less_cols_off = 0; // columns to skip for mark adjust
int less_cols_off = 0; // columns to skip for mark and
// textprop adjustment
pos_T old_cursor; // old cursor position
int newcol = 0; // new cursor column
int newindent = 0; // auto-indent of the new line
Expand Down Expand Up @@ -2151,9 +2152,9 @@ open_line(
did_append = TRUE;
#ifdef FEAT_PROP_POPUP
if ((State & MODE_INSERT) && (State & VREPLACE_FLAG) == 0)
// properties after the split move to the next line
// Properties after the split move to the next line.
adjust_props_for_split(curwin->w_cursor.lnum, curwin->w_cursor.lnum,
curwin->w_cursor.col + 1, 0);
curwin->w_cursor.col + 1, 0);
#endif
}
else
Expand Down Expand Up @@ -2248,6 +2249,12 @@ open_line(
mark_col_adjust(curwin->w_cursor.lnum,
curwin->w_cursor.col + less_cols_off,
1L, (long)-less_cols, 0);
#ifdef FEAT_PROP_POPUP
// Keep into account the deleted blanks on the new line.
if (curbuf->b_has_textprop && less_cols_off != 0)
adjust_prop_columns(curwin->w_cursor.lnum + 1, 0,
-less_cols_off, 0);
#endif
}
else
changed_bytes(curwin->w_cursor.lnum, curwin->w_cursor.col);
Expand Down
12 changes: 12 additions & 0 deletions src/testdir/test_textprop.vim
Expand Up @@ -635,6 +635,18 @@ func Test_prop_open_line()
call assert_equal(expected, prop_list(2))
call DeletePropTypes()

" split at the space character with 'ai' active, the leading space is removed
" in the second line and the prop is shifted accordingly.
let expected = SetupOneLine() " 'xonex xtwoxx'
set ai
exe "normal 6|i\<CR>\<Esc>"
call assert_equal('xonex', getline(1))
call assert_equal('xtwoxx', getline(2))
let expected[1].col -= 6
call assert_equal(expected, prop_list(1) + prop_list(2))
set ai&
call DeletePropTypes()

bwipe!
set bs&
endfunc
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -746,6 +746,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
4955,
/**/
4954,
/**/
Expand Down

0 comments on commit 788c06a

Please sign in to comment.