runtime(stylus): include syntax and ftplugin #14656
Conversation
pheiduck
changed the title
|
Did you check with the maintainers, if they are fine with including it here? In general, it looks like this still requires a bit of more work. |
I pinged all, but if we get no response I desided to not include this. |
|
What is the issue with all those css syntax words? Shouldn't that belong to a separate css syntax script and be sourced for stylus files? |
Not sure, if this is possible to remove without breaking effects. |
|
I'm happy to have stylus.vim be officially supported in VIM. I am quite removed from the project nowadays so I am not up to speed on any best practices that should be employed. The CSS3 file was originally added because the VIM packages at that time were missing a lot of more recent CSS definitions. It is likely that this package can just depend on the bundled CSS syntax without needing that file anymore. |
|
I don't know stylus and I don't know how much it depends on decent html and or CSS support. But I would think, if it requires those syntax to be present, it should 'source/runtime' those syntax files specifically, instead of declaring them all on its own. |
|
can you please make sure, it doesn't error out before sending updated commits here? |
|
okay, I think looks good now |
|
okay, only thing I noticed was missing to reset formatoptions in |
Problem: filetype: stylus files not recognized
Solution: Detect '*.styl' and '*.stylus' as stylus filetype,
include indent, filetype and syntax plugin
(Philip H)
closes: vim/vim#14656
vim/vim@2d919d2
Co-authored-by: Philip H <47042125+pheiduck@users.noreply.github.com>
Problem: filetype: stylus files not recognized
Solution: Detect '*.styl' and '*.stylus' as stylus filetype,
include indent, filetype and syntax plugin
(Philip H)
closes: vim/vim#14656
vim/vim@2d919d2
Co-authored-by: Philip H <47042125+pheiduck@users.noreply.github.com>
Problem: filetype: stylus files not recognized
Solution: Detect '*.styl' and '*.stylus' as stylus filetype,
include indent, filetype and syntax plugin
(Philip H)
closes: vim/vim#14656
vim/vim@2d919d2
Co-authored-by: Philip H <47042125+pheiduck@users.noreply.github.com>
astro depend on this plugin, so bring that upstream too.
@wavded
@tpope
@lepture