DB is not reselected if the redis client disconnects temporarily #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yikes, that's a pretty bad issue |
tj
added a commit
that referenced
this pull request
Aug 4, 2011
DB is not reselected if the redis client disconnects temporarily [cwu]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been getting session objects in my db 0 after setting RedisStore with a different db. (and users losing session data that was in my session db).
This occurs if the client being used by RedisStore disconnects and then reconnects again. When its reconnected it doesn't reselect the proper db (by the nature of the node_redis client).
Related to node_redis issue #86.
I've added the work around noted in issue #86 node_redis.