Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve granularity of printed time #75

Closed
wants to merge 1 commit into from

Conversation

shime
Copy link

@shime shime commented Sep 15, 2014

although I appreciate @marceloboeira's efforts in #69, I don't like
how imprecise the printed time becomes.

to demonstrate, this is how ms converts miliseconds

var time = require('ms')

time(2000)    // '2s'
time(62000)   // '1m'
time(3662000) // '1h'

and this is how humanize-time does it

var time = require('humanize-time')

time(2000)    // '2s'
time(62000)   // '1m, 2s'
time(3662000) // '1h, 1m, 2s'

@marceloboeira
Copy link

@shime my only worry is about position on the screen of this humanize time, but if works its really good stuff.

@lbeschastny
Copy link

👍

1 similar comment
@micky2be
Copy link

👍

@IgorNadj
Copy link

I don't see a reason why this shouldn't be the output of the default :eta flag (rather than adding a separate flag).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants