Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Fix for Cross-site Scripting (XSS) - huntr.dev #1164

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Security Fix for Cross-site Scripting (XSS) - huntr.dev #1164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c66d80e
Fixed XSS
mufeedvh Aug 14, 2020
8700396
Merge pull request #1 from mufeedvh/develop
JamieSlome Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/editable-form/editable-form-utils.js
View file
Open in desktop
Expand Up @@ -41,22 +41,27 @@
* for details see http://stackoverflow.com/questions/7410348/how-to-set-json-format-to-html5-data-attributes-in-the-jquery
*/
tryParseJson: function(s, safe) {
if (typeof s === 'string' && s.length && s.match(/^[\{\[].*[\}\]]$/)) {
if (safe) {
try {
if (typeof s === 'string' && s.length) {
try {
JSON.parse(s);
if (safe) {
try {
/*jslint evil: true*/
s = (new Function('return ' + s))();
/*jslint evil: false*/
} catch (e) {} finally {
return s;
}
} else {
/*jslint evil: true*/
s = (new Function('return ' + s))();
/*jslint evil: false*/
} catch (e) {} finally {
return s;
}
} else {
/*jslint evil: true*/
s = (new Function('return ' + s))();
/*jslint evil: false*/
return s;
} catch (e) {
// pass
}
}
return s;
},

/**
Expand Down